On Mon, 21 Sep 2020 19:36:03 GMT, Andy Herrick <herr...@openjdk.org> wrote:
>> 8253149: Building an installer from invalid app image fails on Windows and >> Linux >> When jpackage builds a package from an app-image that was not generated by >> jpackage, the tool should give user a >> warning message, and then complete the package anyway. > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev > excludes the unrelated changes brought in by the merge/rebase. The pull > request contains three additional commits since > the last revision: > - 8253149: Building an installer from invalid app image fails (revision 1) > - Merge branch 'master' into JDK-8253149 > - 8253149: Building an installer from invalid app image fails on Windows and > Linux test/jdk/tools/jpackage/share/AppImagePackageTest.java line 26: > 24: import java.nio.file.Path; > 25: import java.nio.file.Files; > 26: import java.io.BufferedWriter; Seems like this import is not needed any more. src/jdk.incubator.jpackage/linux/classes/jdk/incubator/jpackage/internal/resources/LinuxResources.properties line 64: > 62: message.rpm-ldd-not-available.advice=Install "glibc-common" RPM package > to get ldd. > 63: > 64: warning.forign-app-image=Warning: app-image dir not generated by jpackage. Should it be "foreign" instead of "forign"? ------------- PR: https://git.openjdk.java.net/jdk/pull/271
