On Tue, 22 Sep 2020 15:11:57 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Alexey Bakhtin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8245527: version.01
>
> src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java
> line 156:
>
>> 154: if (props != null) {
>> 155: // TLS Channel Binding
>> 156: byte[] tlsCB =
>> (byte[])props.get("jdk.internal.sasl.tlschannelbinding");
>
> You can say the name is defined in another class in another module. If we
> really want to rename it one day we will know
> where it's from.
Thank you. Comment is added
> src/java.security.jgss/share/classes/sun/security/jgss/krb5/InitialToken.java
> line 389:
>
>> 387: int acceptorAddressType = getAddrType(acceptorAddress,
>> 388: (channelBinding instanceof TlsChannelBindingImpl)?
>> 389:
>> CHANNEL_BINDING_AF_UNSPEC:CHANNEL_BINDING_AF_NULL_ADDR);
>
> Normally we put a white space around "?" and ":".
Thank you. Fixed.
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java
> line 82:
>
>> 80: /**
>> 81: * Parse value of "com.sun.jndi.ldap.tls.cbtype" property
>> 82: * @param cbType
>
> Please add a `@return` here, esp, about null.
Added @return with comments
> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java
> line 137:
>
>> 135: public TlsChannelBindingType getType() {
>> 136: return cbType;
>> 137: }
>
> Add a new line here.
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/278
