On Wed, 23 Sep 2020 02:32:46 GMT, Joe Darcy <[email protected]> wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review comments - improving javadoc, avoid repeated search of
>> modules that have already been searched.
>
> src/java.compiler/share/classes/javax/lang/model/util/Elements.java line 62:
>
>> 60: * <li>find non-empty packages with the given name returned by
>> 61: * {@link #getPackageElement(ModuleElement, CharSequence)},
>> 62: * where the provided ModuleSymbol is any root module,
>
> Does "root module" mean one of the modules in the result of
> Elements.getAllModuleElements? If so, I suggest making
> "root module" a link to the method.
Root module is meant in the java.lang.module sense, i.e. the set of modules
that are being compiled. In a new revision,
I added a link to the appropriate package javadoc in java.lang.module; and a
link to getAllModules for "all modules" in
the next point. Does this make sense?
I've generated the javadoc for convenience here:
http://cr.openjdk.java.net/~jlahoda/8236842/docsv2/api/java.compiler/javax/lang/model/util/Elements.html#getTypeElement(java.lang.CharSequence)
http://cr.openjdk.java.net/~jlahoda/8236842/docsv2/api/java.compiler/javax/lang/model/util/Elements.html#getPackageElement(java.lang.CharSequence)
-------------
PR: https://git.openjdk.java.net/jdk/pull/200
