On Thu, 24 Sep 2020 22:05:34 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> 8253379: [windows] Several jpackage tests failed with error code 1638 >> two windows specific test fixes in WindowsHelper: >> 1.) do not test that the parent directory of a windows menu shortcut is >> empty after shortcut is uninstalled (there may >> be other shortcuts using that directory) 2.) do not programmatically install >> windows exe installers (since we have no >> way of programmatically uninstalling them) > > According to msiexec help, msiexec supports ProductCode for uninstall "/x | > Package|ProductCode". Do you know if it > would be possible to use such options? Currently msi wrapper unconditionally adds "/i" on msiexec command line. So passing "/x" option to exe installer would not work. I think we need to rework msi wrapper to only support one command line option - "--uninstall" instead of passing all command line parameters to nested msiexec invocation. ------------- PR: https://git.openjdk.java.net/jdk/pull/337
