On Tue, 20 Oct 2020 16:42:46 GMT, CoreyAshford <github.com+51754783+coreyashf...@openjdk.org> wrote:
> @CoreyAshford apologies i pointed to the "umbrella" test that runs Graal unit > tests, the actual test is > [CheckGraalIntrinsics](https://github.com/openjdk/jdk/blob/master/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java) > See this PR for an example: #762 I believe I have a fix for this, but I'm having trouble running the test case. I wasn't even aware of this test suite before, so I've been trying to figure out how to correctly run it. Here's what I'm seeing: % pwd % ~/git-trees/mx/mx --java-home /home/cjashfor/git-trees/jdk/build/linux-x86_64-server-slowdebug/jdk -v unittest CheckGraalIntrinsics Setting environment variable JAVA_HOME=/home/cjashfor/git-trees/jdk/build/linux-x86_64-server-slowdebug/jdk from --java-home env JAVA_HOME=/home/cjashfor/git-trees/jdk/build/linux-x86_64-server-slowdebug/jdk MX_SUBPROCESS_COMMAND_FILE=/tmp/mx_subprocess_command.LLxLCx MX_HOME=/home/cjashfor/git-trees/mx MX_PRIMARY_SUITE_PATH=/home/cjashfor/git-trees/jdk/src/hotspot MX__SUITEMODEL=sibling \ [all files are up to date - skipping com.oracle.mxtool.junit.jdk9] [all files are up to date - skipping com.oracle.mxtool.junit] [skipping JUNIT_TOOL] Traceback (most recent call last): File "/home/cjashfor/git-trees/mx/mx.py", line 17030, in <module> main() File "/home/cjashfor/git-trees/mx/mx.py", line 17011, in main retcode = c(command_args) File "/home/cjashfor/git-trees/mx/mx_commands.py", line 147, in __call__ return self.command_function(*args, **kwargs) File "/home/cjashfor/git-trees/mx/mx_unittest.py", line 487, in unittest _unittest(args, ['@Test', '@Parameters'], junit_args, **parsed_args.__dict__) File "/home/cjashfor/git-trees/mx/mx_unittest.py", line 319, in _unittest _run_tests(args, harness, vmLauncher, annotations, testfile, blacklist, whitelist, regex, mx.suite(suite) if suite else None) File "/home/cjashfor/git-trees/mx/mx_unittest.py", line 179, in _run_tests if vmLauncher.jdk().javaCompliance < p.javaCompliance: AttributeError: 'NoneType' object has no attribute 'javaCompliance' Any ideas? ------------- PR: https://git.openjdk.java.net/jdk/pull/293
