On Thu, 22 Oct 2020 16:31:00 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Some of this is familiar to me from reviews in the `panama-foreign` >> repository, but less so than the memory API. I focused on the Java code, and >> ignored changes that are common with the memory API PR. >> >> If it helps in can provide a PR in the `panama-foreign` repository >> addressing editorial comments to the linker API. > > I've just uploaded a new iteration which addresses most of @PaulSandoz > comments on the API/Java impl. The most recent changes address Coleen's review comments on: #1 The changes I've made are: - Use TempNewSymbol when creating a symbol in field_offset & find_InstanceKlass - change JVM_* macros -> JNI_* - rename parseABIDescritpor & parseBufferLayout -> parse_abi_descriptor & parse_buffer_layout - remove ref to global function using '::', by merging the 2 functions together - make 2 functions static, instead of ForeignGlobals class members ------------- PR: https://git.openjdk.java.net/jdk/pull/634
