On Wed, 4 Nov 2020 22:13:25 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Hi, >> >> Please review the changes for the subject issue. This is to enhance the >> java.time package to support day periods, such as "in the morning", defined >> in CLDR. It will add a new pattern character 'B' and its supporting builder >> method. The motivation and its spec are in this CSR: >> >> https://bugs.openjdk.java.net/browse/JDK-8254629 >> >> Naoto > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains ten additional commits since > the last revision: > > - Merge branch 'master' into dayperiod > - Change based on CSR change. > - Fixed TCK test failures, added the new pattern char description in > DateTimeFormatter > - Addressing https://github.com/openjdk/jdk/pull/938#discussion_r516147298 > - Addressing https://github.com/openjdk/jdk/pull/938#discussion_r516123190 > - Addressing https://github.com/openjdk/jdk/pull/938#discussion_r516138455 > - Fixed exception messages. > - Addressed the following comments: > - https://github.com/openjdk/jdk/pull/938#discussion_r515003422 > - https://github.com/openjdk/jdk/pull/938#discussion_r515005296 > - https://github.com/openjdk/jdk/pull/938#discussion_r515008862 > - https://github.com/openjdk/jdk/pull/938#discussion_r515030268 > - https://github.com/openjdk/jdk/pull/938#discussion_r515030880 > - https://github.com/openjdk/jdk/pull/938#discussion_r515032002 > - https://github.com/openjdk/jdk/pull/938#discussion_r515036803 > - https://github.com/openjdk/jdk/pull/938#discussion_r515037626 > - https://github.com/openjdk/jdk/pull/938#discussion_r515038069 > - https://github.com/openjdk/jdk/pull/938#discussion_r515039056 > - 8247781: Day periods support src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 1479: > 1477: * for it in the formatter locale is from 21:00 to 06:00, then > {@code HOUR_OF_DAY} > 1478: * is set to '1' and {@code MINUTE_OF_HOUR} set to '30'. If {@code > AMPM_OF_DAY} exists > 1479: * and no {@code HOUR_OF_DAY} is resolved, the parsed day period > takes the precedence. "the precedence" -> "precedence" ------------- PR: https://git.openjdk.java.net/jdk/pull/938
