On Mon, 9 Nov 2020 03:52:27 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 64 commits: >> >> - Merge branch '8254162' into 8254231_linker >> - Fix post-merge issues caused by 8219014 >> - Merge branch 'master' into 8254162 >> - Addess remaining feedback from @AlanBateman and @mrserb >> - Address comments from @AlanBateman >> - Fix typo in upcall helper for aarch64 >> - Merge branch '8254162' into 8254231_linker >> - Merge branch 'master' into 8254162 >> - Fix issues with derived buffers and IO operations >> - More 32-bit fixes for TestLayouts >> - ... and 54 more: >> https://git.openjdk.java.net/jdk/compare/a50fdd54...b38afb3f > > src/hotspot/share/prims/universalNativeInvoker.cpp line 40: > >> 38: assert(thread->thread_state() == _thread_in_native, "thread state >> is: %d", thread->thread_state()); >> 39: } >> 40: assert(thread->thread_state() == _thread_in_vm, "thread state is: %d", >> thread->thread_state()); > > Is there some reason you don't trust the thread-state transition code and are > asserting it updates the state correctly all the time? :) There are already a > number of assertions of this kind within the ThreadToNativeFromVM code. Pre-existing code (to me at least). I agree it seems unnecessary, I'll remove the asserts. ------------- PR: https://git.openjdk.java.net/jdk/pull/634
