On Tue, 10 Nov 2020 21:26:59 GMT, Lance Andersen <[email protected]> wrote:
> Hi,
>
> Please review the fix for JDK-8256018 which addresses the issue that the
> update(ByteBuffer) methods of Adler32, CRC32, and CRC32C should use
> Reference.reachabilityFence to ensure that direct byte buffer are kept kept
> alive when they are accessed directly.
>
> The Mach5 jdk-tier1, jdk-tier2, jdk-tier3 as well as the
> jck:api/java_util/zip,jck:api/java_util/jar continue to run clean.
>
> Best
> Lance
Marked as reviewed by alanb (Reviewer).
src/java.base/share/classes/java/util/zip/Adler32.java line 103:
> 101: try {
> 102: adler = updateByteBuffer(adler,
> ((DirectBuffer)buffer).address(), pos, rem);
> 103:
spurious blank line here but otherwise looks good.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1149
