On Wed, 11 Nov 2020 12:44:56 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with 10 >> additional commits since the last revision: >> >> - Merge pull request #7 from JornVernee/Additional_Review_Comments >> >> Additional review comments >> - Revert System.java changes >> - Set copyright year for added files to 2020 >> - Check result of AttachCurrentThread >> - Sort includes alphabetically >> - Relax ret_addr_offset() assert >> - Extra space after if >> - remove excessive asserts in ProgrammableInvoker::invoke_native >> - Remove os::is_MP() check >> - remove blank line in thread.hpp > > src/hotspot/share/opto/callnode.cpp line 1143: > >> 1141: case TypeFunc::Parms: >> 1142: default: { >> 1143: if(tf()->range()->field_at(proj->_con) == Type::HALF) { > > That's `TypeFunc::Parms+1` case in `CallNode::match`. Why did you decide to > move it to `default` case? > > Overall, it looks very similar to `CallNode::match`. Why not just customize > `OptoRegPair regs` computation for `CallNative` there? For native calls we can have multiple return values, at least in theory. Currently this is not the case though. Will take another look. ------------- PR: https://git.openjdk.java.net/jdk/pull/634