On Wed, 11 Nov 2020 18:19:01 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename inactive-getter and improve javadocs
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 356:
>
>> 354: */
>> 355: T getInactive() {
>> 356: return this.referent;
>
> It would be good to add `assert this instanceof FinalReference` to make this
> assertion clear.
Right. And maybe also assert that the Reference is indeed inactive. I'll open a
new issue for that (I already integrated this one, sorry I kinda jumped the gun
a little.)
-------------
PR: https://git.openjdk.java.net/jdk/pull/1140
