On Mon, 16 Nov 2020 19:07:55 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Changes requested by asemenyuk (Committer).
>
> In these two scenarios what would be the name of the installer:
> 1. phase 1: --name Foo; phase 2: --name Bar --app-image
> <path_to_image_from_phase_1>
> 2. phase 1: --name Foo; phase 2: --app-image <path_to_image_from_phase_1>
>
> Do we have tests for these two scenarios?
In scenario 1, the installer would be Bar-1.0.{exe, msi, pkg ...}
The change in test above tests this.
Scenario 2 would be an error currently, since all jpackage commands require a
"--name" argument, however, it would be reasonable to modify restriction to
require either a name or an app-image, extracting the name from the app-image
in this case.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1229
