On Thu, 19 Nov 2020 16:49:23 GMT, Andy Herrick <herr...@openjdk.org> wrote:
>> …n name. > > Andy Herrick has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 69 additional > commits since the last revision: > > - JDK-8256475: Fix Behavior when Installer name differs from application > name. > - Merge branch 'master' into JDK-8256475 > - 8221554: aarch64 cross-modifying code > > Reviewed-by: rehn, aph > - 8255978: [windows] os::release_memory may not release the full range > > Reviewed-by: iklam, minqi > - 8256375: AArch64: aarch64-asmtest.py may generate undefined register r18 > > Reviewed-by: aph > - 8252304: Seed an HttpRequest.Builder from an existing HttpRequest > > Co-authored-by: Chris Hegarty <che...@openjdk.org> > Reviewed-by: chegar, dfuchs, michaelm > - 8256499: Zero: enable Epsilon GC > > Reviewed-by: rkennke, ihse > - 8256552: Let ReplayCompiles set UseDebuggerErgo > > Reviewed-by: vlivanov, redestad > - 8256172: Clean up CDS handling of i2i_entry > > Reviewed-by: minqi, ccheung > - 8256178: Add RAII object for file lock > > Reviewed-by: dholmes, coleenp > - ... and 59 more: > https://git.openjdk.java.net/jdk/compare/64b64ac9...2e044b91 test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java line 218: > 216: } > 217: > 218: public String installerName() { I'd suggest to insert `verifyIsOfType(PackageType.NATIVE);` call at the beginning of the function body. This will help to catch situations if installerName() is called on jpackage command building app image by accident. test/jdk/tools/jpackage/share/MultiNameTwoPhaseTest.java line 37: > 35: > 36: /* > 37: * @test Without ` * @requires jpackage.test.SQETest == null` this test will be used to create test artifacts for SQE. I don't think we need any manual testing here. Especially for five test scenarios. I think automated testing should be sufficient. ------------- PR: https://git.openjdk.java.net/jdk/pull/1300
