On Thu, 19 Nov 2020 23:08:21 GMT, Mark Reinhold <m...@openjdk.org> wrote:
>> Please review this implementation of JEP 396 >> (https://openjdk.java.net/jeps/396). >> Alan Bateman is the original author; I’ve credited him in the commit >> metadata. >> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64. > > Mark Reinhold has updated the pull request incrementally with one additional > commit since the last revision: > > Add "Add-Exports" case for the > setAccessibleNonPublicMemberNonExportedPackage test The hostpot change is trivially fine. I'm somewhat surprised by the extent of the other changes given the basic change here is to deprecate the option and change its default. I literally expected to see only 2 simple changes to the functional code: the deprecation warning and the changing of the default value. ------------- PR: https://git.openjdk.java.net/jdk/pull/1324