On Sat, 28 Nov 2020 14:10:10 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8254082: Consolidate putStringAt() methods: make length represent char >> count > > Looks good to me. > > Theoretically the refactored `getBytes(byte[], int, byte)` should have no > cost, but could cause some issues in some microbenchmarks that touches this. > You mentioned this was used by StringConcatHelper, so could you run the > org.openjdk.bench.java.lang.StringConcat micros to check that there are no > regressions? > @cl4es Could you tell me where I can look for a command to run the benchmark? See [doc/testing.md](https://github.com/openjdk/jdk/blob/master/doc/testing.md). The [configuration](https://github.com/openjdk/jdk/blob/master/doc/testing.md#configuration) section has a pointer on how to set up and configure the JDK build with JMH, then it should be a simple matter of running `make test TEST=micro:org.openjdk.bench.java.lang.StringConcat`. ------------- PR: https://git.openjdk.java.net/jdk/pull/402
