On Thu, 3 Dec 2020 15:52:35 GMT, Daniel Fuchs <[email protected]> wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleInfo.java line 1203:
>>
>>> 1201: @Override
>>> 1202: public String readUTF() throws IOException {
>>> 1203: return DataInputStream.readUTF(this);
>>
>> If i understand correctly the code, I believe readUTF should change a
>> boolean field named `countCanNotBeTrackedAnymore` from false to true, and in
>> the method `count()`, `countCanNotBeTrackedAnymore` has to be checked and
>> throws an ISE before returning `count`
>
> Hi Rémi, I do not think that that is required. `DataInputStream.readUTF` will
> call back into `this` to do the reading so the `count` should be properly
> incremented? Or maybe I'm missing something. Best regards!
Thanks,
i should have read the code more carefully.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1407
