On Mon, 7 Dec 2020 23:52:29 GMT, Brent Christian <bchri...@openjdk.org> wrote:

>> Please review this fix for the intermittently-failing 
>> java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java.
>> 
>> The change replaces System.gc()+sleep() with the more robust gcAwait() 
>> mechanic used elsewhere in the test base, [as pointed out by 
>> Martin](https://bugs.openjdk.java.net/browse/JDK-8200102?focusedCommentId=14382648&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14382648)(thanks!).
>> 
>> The new version of the test passes 100 times out of 100 on the test farm.
>
> Brent Christian has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains five additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into 8200102
>  - Copyright date and indentation cleanup
>  - Merge branch 'master' into 8200102
>  - Use existing ForceGC class in the test lib
>  - Add gcAwait() mechanism

Looks good!

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1630

Reply via email to