On Mon, 7 Dec 2020 19:59:40 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Athijegannathan Sundararajan has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> renamed the test as per review comment.
>
> test/jdk/jdk/internal/jrtfs/Test8242258.java line 40:
>
>> 38: import static org.testng.Assert.assertEquals;
>> 39:
>> 40: public class Test8242258 {
>
> I think it would be better to create something like UriTests that we can add
> further tests for jrtfs URIs as they arise.
I'll renamed the test
> test/jdk/jdk/internal/jrtfs/Test8242258.java line 60:
>
>> 58: { "xyz ", "jrt:/xyz%20" },
>> 59: { "xy z", "jrt:/xy%20z" },
>> 60: };
>
> One other thing we test here is a malformed escape pair, e.g. "jrt:/%5" and
> check that getPath(URI) throws IAE.
URI.create(String) method itself checks for malformed escape pairs. Do we need
anything additional here?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1669
