On Tue, 8 Dec 2020 10:17:48 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

> > > `-Xm3800M` could still fail on many 32-bit systems, for example where 
> > > native libraries are located in the middle of address space. I think it 
> > > is safer to `@require` it. In fact, I did it an hour ago here #1688 :)
> > 
> > 
> > The test just limits the maximum memory to be used, not the minimum memory.
> > So I think the foreign api should also work on 32-bit platforms.
> 
> Well, I think the test still fails with your fix: 
> https://github.com/DamonFool/jdk/runs/1516430124 -- as I suspected it would :(

OK.
It seems the test is brittle on 32-bit platforms.
I agree with you now.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1689

Reply via email to