On Wed, 16 Dec 2020 07:10:41 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   improve SERIAL_FILTER_PATTERN comment
>
> src/java.base/share/classes/java/util/Locale.java line 1649:
> 
>> 1647:      * <p>This implements the 'Language-Tag' production of BCP47, and
>> 1648:      * so supports legacy (regular and irregular, referred to as
>> 1649:      * {@code Type: grandfathered} in BCP47) as well as
> 
> You might consider putting quotes around "Type; grandfathered" here, 
> otherwise looks good.

Yes, having that in quotes instead of in {@code} would be consistent with the 
rest of Locale.java.  I will change that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1771

Reply via email to