Hi Christoph,
thanks for the review!
Best regards,
Martin
> -----Original Message-----
> From: Langer, Christoph <christoph.lan...@sap.com>
> Sent: Donnerstag, 17. Dezember 2020 14:45
> To: Doerr, Martin <martin.do...@sap.com>; core-libs-dev <core-libs-
> d...@openjdk.java.net>; jdk-updates-...@openjdk.java.net
> Subject: RE: [11u] RFR: 8211825: ModuleLayer.defineModulesWithXXX does
> not setup delegation when module reads automatic module
>
> Hi Martin,
>
> this makes sense. Thanks for doing the backport.
>
> Best regards
> Christoph
>
> > -----Original Message-----
> > From: core-libs-dev <core-libs-dev-r...@openjdk.java.net> On Behalf Of
> > Doerr, Martin
> > Sent: Mittwoch, 16. Dezember 2020 14:39
> > To: core-libs-dev <core-libs-dev@openjdk.java.net>; jdk-updates-
> > d...@openjdk.java.net
> > Subject: [CAUTION] [11u] RFR: 8211825:
> > ModuleLayer.defineModulesWithXXX does not setup delegation when
> > module reads automatic module
> >
> > Hi,
> >
> > JDK-8211825 is backported to 11.0.11-oracle. I'd like to backport it for
> > parity.
> > The original change applies cleanly, by javac from 11u has a problem with
> the
> > new AutomaticModulesTest:
> > AutomaticModulesTest.java:70: error: reference to createJarFile is
> > ambiguous
> > JarUtils.createJarFile(LIB.resolve("alib.jar"), CLASSES);
> > ^
> > both method createJarFile(Path,Path,Path...) in JarUtils and method
> > createJarFile(Path,Path,String...) in JarUtils match
> >
> > I suggest to resolve it this way:
> >
> http://cr.openjdk.java.net/~mdoerr/8211825_module_layer_11u/test_fix.p
> > atch
> >
> >
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8211825
> >
> > Original change:
> > http://hg.openjdk.java.net/jdk/jdk/rev/a42c378b6f01
> >
> > 11u webrev:
> >
> http://cr.openjdk.java.net/~mdoerr/8211825_module_layer_11u/webrev.0
> > 0/
> >
> > Please review.
> >
> > Best regards,
> > Martin
