On Mon, 21 Dec 2020 15:34:16 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Jie Fu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Ignore OOME for testOOME >> - Revert the change > > Completely ignoring the exception will leave no trace that the test was > skipped or why. > Please retain the printing of the memory limits and instead of rethrowing the > oome add: > new SkipException("Insufficient Memory to test OOME");``` > (It will need an import of org.testng.SkipException). > Throwing SkipException will flag the test as being skipped in the Jtreg > summary. > Completely ignoring the exception will leave no trace that the test was > skipped or why. > Please retain the printing of the memory limits and instead of rethrowing the > oome add: > `throw new SkipException("Insufficient Memory to test OOME");` > (It will need an import of org.testng.SkipException). > Throwing SkipException will flag the test as being skipped in the Jtreg > summary. Updated. Thanks for your help. ------------- PR: https://git.openjdk.java.net/jdk/pull/1817