On Tue, 5 Jan 2021 01:03:55 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org> 
wrote:

> Vector conversion with part > 0 is implemented using slice(origin, vector) 
> instead of slice(origin).
> The slice(origin) has intrinsic implementation whereas slice(origin, vector) 
> doesn’t.
> Slice(origin) is written using vector API methods like rearrange and blend 
> which all have intrinsic implementations.
> Also, VectorIntrinsics.VECTOR_ACCESS_OOB_CHECK code is missing from rearrange 
> checkIndexes.
> 
> Please review this patch which fixes the above issue.
> 
> Best Regards,
> Sandhya

Looks good. Can you please update the copyright year before integrating?

I notice the issue is not assigned to you, unsure of Skara will make it so once 
integrated.

-------------

Marked as reviewed by psandoz (Reviewer).

PR: https://git.openjdk.java.net/jdk16/pull/79

Reply via email to