On Sat, 16 Jan 2021 17:49:38 GMT, eirbjo <[email protected]> wrote:
> ZipFile.Source.initCEN verifies that entry names are encoding into bytes > valid in the entry's encoding. It does so by calling encoding-specific > checking methods, so it also needs to determine which check method to call > for each entry. > > By moving the encoding-variant checks into ZipCoder, initCEN can instead > simply call ZipCoder.checkEncoding. This makes the code easier to follow and > also removes a duplication of flag checking logic found in zipCoderForPos. Welcome back! Patch looks good to me. I'll sponsor it after allowing some time for other reviewers to have a look. ------------- Marked as reviewed by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2110
