On Wed, 20 Jan 2021 13:33:30 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move JLA to top, add imports > > test/micro/org/openjdk/bench/java/io/FileOpen.java line 103: > >> 101: @Warmup(time=2, iterations=5) >> 102: @Measurement(time=3, iterations=5) >> 103: @Fork(value=2, jvmArgs="-Xmx1g") > > I thought this can be inherited from the enclosing benchmark. Maybe it's only @State that doesn't inherit. > test/micro/org/openjdk/bench/java/io/FileOpen.java line 104: > >> 102: @Measurement(time=3, iterations=5) >> 103: @Fork(value=2, jvmArgs="-Xmx1g") >> 104: public static class ToPath { > > Do we really have to nest this test? It seems to gain nothing per se: the > annotations and fields are still pretty much duplicated. Yeah, no. Nesting was to pre-emptively decouple the micros, but it makes sense to squash them into one for now. ------------- PR: https://git.openjdk.java.net/jdk/pull/2135