On Fri, 29 Jan 2021 17:31:09 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Updates to the specifications of Double.{equals, compareTo} to explain more >> explicitly why the obvious wrappers around "==" and "<"/"==" are not >> sufficient for floating-point values. >> >> Once the wording is worked out, I'll replicate it for the analogous methods >> on Float. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains six additional commits since > the last revision: > > - Merge branch 'master' into JDK-8257086 > - Update reworked wording from @smarks. > - Merge branch 'master' into JDK-8257086 > - Merge branch 'master' into JDK-8257086 > - Fix whitespace > - Initial work for JDK-8257086. Overall good! Just some whitespace errors and a couple typos as noted. src/java.base/share/classes/java/lang/Double.java line 117: > 115: * > 116: * <p>To provide the appropriate semantics for {@code equals} and {@code > 117: * compareTo} methods, those methods cannot simply to wrappers around I think this should be "cannot simply be wrappers". ------------- Marked as reviewed by smarks (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1699