On Mon, 1 Feb 2021 20:10:58 GMT, Ioi Lam <[email protected]> wrote:
>> - JVM_GetInterfaceVersion() was used by "HotSpot Express" (HSX) which
>> allowed the same JDK library to use different version of HotSpot. However,
>> HSX is no longer supported so this API should be removed.
>> - Implementations of APIs such as JVM_DTraceActivate, were removed in
>> [JDK-8068976](https://bugs.openjdk.java.net/browse/JDK-8068976), so their
>> declarations should be removed from jvm.h
>
> Ioi Lam has updated the pull request incrementally with one additional commit
> since the last revision:
>
> fixed macos build
Changes requested by gziemski (Committer).
src/java.base/share/native/libjava/check_version.c line 33:
> 31: DEF_JNI_OnLoad(JavaVM *vm, void *reserved)
> 32: {
> 33: return JNI_VERSION_1_2;
This leaves an entire file with one trivial function implementation. Can we
remove the file and implement `DEF_JNI_OnLoad()` in `jni_util.h` (or some
other existing suitable file) ?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2338
