On Wed, 3 Feb 2021 12:08:58 GMT, Claes Redestad <[email protected]> wrote:
> This moves the tracing methods added to GenerateJLIClassesHelper in
> JDK-8252725 to MethodHandleStatics, which avoids loading at runtime some code
> meant for jlink.
Marked as reviewed by mchung (Reviewer).
src/java.base/share/classes/java/lang/invoke/MethodHandleStatics.java line 68:
> 66: // classes that have been or could have be pre-generated
> 67: static final String LF_RESOLVE = "[LF_RESOLVE]";
> 68: static final String SPECIES_RESOLVE = "[SPECIES_RESOLVE]";
It is okay with me to simply hardcode these strings in GenerateJLIClassesHelper
and the trace methods.
src/java.base/share/classes/java/lang/invoke/MethodHandleStatics.java line 121:
> 119:
> 120: /*non-public*/
> 121: static void traceLambdaForm(String name, MethodType type, Class<?>
> holder, MemberName resolvedMember) {
It'd be help to add a comment describing what these trace methods are for.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2376
