On Fri, 5 Feb 2021 03:00:05 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comments and copyright. > > src/hotspot/share/classfile/javaClasses.cpp line 4415: > >> 4413: >> 4414: // This field means that a security manager can be installed so we >> still have to >> 4415: // populate the ProtectionDomainCacheTable. > > No this field returns the installed SM if any. It doesn't tell you anything > about whether you can install a SM or not (though obviously if non-NULL then > you could). // This field tells us that a security manager is installed. How about I just put this. I had a bug earlier that this explained to me but the allow_security_manager() also explains it. > src/java.base/share/classes/java/lang/System.java line 163: > >> 161: >> 162: // indicates if a security manager is possible >> 163: // @implNote The HotSpot JVM hardcodes the value of NEVER. > > You don't need this if the VM reads the value of NEVER. ok. ------------- PR: https://git.openjdk.java.net/jdk/pull/2410
