On Sun, 7 Feb 2021 09:15:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Though looking at that piece of code, I think its purpose would be clearer >> if it were put in a separate method with a name that shows were trying to >> open it as a socket. > > Moving it to a separate method would make it easier to maintain and discuss > here but I would really prefer if it checked the reparse tag and re-throw the > original exception if the tag is IO_REPARSE_TAG_SYMLINK. That way it wouldn't > get tripped up by ERROR_CANT_ACCESS_FILE being thrown for other reasons, e.g. > sym link -> sym link -> target where an intermediate sym link can't be > accessed. Okay, I can add a check for WindowsFileAttributes.isUnixDomainSocket() in there when ERROR_CANT_ACCESS_FILE is returned. ------------- PR: https://git.openjdk.java.net/jdk/pull/2424
