On Mon, 8 Feb 2021 22:58:13 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

>> src/java.base/share/classes/java/io/FilterReader.java line 81:
>> 
>>> 79:      * {@inheritDoc}
>>> 80:      *
>>> 81:      * @throws     IllegalArgumentException  If {@code n} is negative 
>>> and the
>> 
>> Does this have to be different from the `Reader.skip()`'s description? Since 
>> the contained reader implements `Reader` (throws IAE as a contract), that 
>> condition after `and` is always true?
>
> This came from some `Reader`s, e.g., `CharArrayReader`, `StringReader`, 
> overriding `skip()` _not_ to throw an IAE. But at the specification level 
> perhaps this should not be recognized.

Makes sense. Then I would let CSR decide whether to include the description or 
not.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2274

Reply via email to