On Tue, 9 Feb 2021 00:20:25 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> SonarCloud instance reports as new warning after JDK-8254702: >> >> This branch can not be reached because the condition duplicates a previous >> condition in the same sequence of "if/else if" statements. >> >> char* getJvmLauncherLibPath(void) { >> ... >> if (PACKAGE_TYPE_RPM == pkg->type) { >> pkgQueryCmd = "rpm -ql '%s' 2>/dev/null"; >> } else if (PACKAGE_TYPE_RPM == pkg->type) { <--- here >> pkgQueryCmd = "dpkg -L '%s' 2>/dev/null"; >> >> Seems like an obvious typo. >> >> Additional tests: >> - [x] Linux x86_64 (Ubuntu) `tools/jpackage` > > Marked as reviewed by almatvee (Committer). Ah. Still looking for formal Reviewer to ack. ------------- PR: https://git.openjdk.java.net/jdk/pull/2452