On Thu, 11 Feb 2021 17:38:42 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> src/java.base/macosx/native/libjava/java_props_macosx.c line 250: >> >>> 248: >>> 249: NSString *nsVerStr; >>> 250: // Copy out the char* if running on version other than >>> pre-10.16 Mac OS (10.16 == 11.x) >> >> Isn't the comment backwards from what the test does? I would think it should >> be "if running on version other than 10.16 Mac OS ...". Or am I missing >> something? > > @kevinrushforth I think you are correct. This is actually mea culpa I think > as I had provided in a Slack thread a failed attempt at a patch for this > which contained this comment. So the words "other than" are too subtle? ------------- PR: https://git.openjdk.java.net/jdk/pull/2530
