On Thu, 11 Feb 2021 19:51:43 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits since the last revision: >> >> - Fix jcheck >> - Add documentation and reduce code running in the critical section >> - Add some documentation >> - Merge branch 'master' into jdk-8254001-enhance-file-parsing-java-metrics >> - Merge branch 'master' into jdk-8254001-enhance-file-parsing-java-metrics >> - Merge branch 'master' into jdk-8254001-enhance-file-parsing-java-metrics >> - 8254001: [Metrics] Enhance parsing of cgroup interface files for version >> detection > > Hi Severin, > Thanks for doing this! Sorry for taking so long to review this change. The > change looks good. Before pushing it, could you add a comment explaining > what the code in lines 185-194 of CgroupSubsystemFactory.java is doing? > Also, please don't overwrite the fix for JDK-8257746. > Thanks again! Harold Setting reviewers to 2 since I want @gnu-andrew to be OK with it too. ------------- PR: https://git.openjdk.java.net/jdk/pull/1393
