On Mon, 15 Feb 2021 13:40:26 GMT, Christoph Langer <clan...@openjdk.org> wrote:
>> After the fix for JDK-8253702, the test java/lang/System/OsVersionTest.java >> still fails on BigSur versions that have a patch version (> 1), e.g. on >> macOS Big Sur 11.2.1, and where the JDK was built with xcode < 12. >> >> java.lang.Error: 11.2 != 11.2.1 >> >> This is a proposal to relax the test and throw a SkippedException in such >> cases. > > Throwing a SkippedException upon the special failure condition is just one > possible suggestion. Alternatively we can also allow this as success > condition. > I'm also wondering whether we should run this test with the various > possibilities for SYSTEM_VERSION_COMPAT settings. > > All under the assumption that we can't figure out the patch version of the > macOS we run on. > > Thoughts? Given the lack of veracity from the os... Perhaps check that `swVersion.startsWith(osVersion) == true` (if the whole string doesn't match). I'm hopeful that when JDK 17 is released the toolchain has been upgraded and this patch won't be necessary. But if someone suggests backporting it, then a more through testing is needed. ------------- PR: https://git.openjdk.java.net/jdk/pull/2576
