On Tue, 9 Mar 2021 16:50:40 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Add support to insert dialog with prompts to create shortcuts in dialog 
>> installation sequence of Windows installers created by jpackage.
>> 
>> Dialog look:
>> ![shortcut_prompt](https://user-images.githubusercontent.com/69478316/110511049-d3828a80-80d1-11eb-8db5-392d5c11c670.png)
>> 
>> As a side effect of the fix, UI-related WiX source code was moved from 
>> main.wxs into generated ui.wxf file. Users can override ui.wxf by placing a 
>> file with this name in resource directory.
>> Source code of custom dialogs optionally inserted in dialog installation 
>> sequence were placed in distinct WiX sources: InstallDirNotEmptyDlg.wxs and 
>> ShortcutPromptDlg.wxs. They can be overridden if files with the 
>> corresponding names as placed in resource directory.
>> Moving source code of installer UI from main.wxs into ui.wxf, 
>> InstallDirNotEmptyDlg.wxs and ShortcutPromptDlg.wxs files supposed to 
>> simplify overriding of the default UI provided by jpackage.
>
> Alexey Semenyuk has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains two commits:
> 
>  - 8241716: Jpackage functionality to let users choose whether to create 
> shortcuts
>  - 8241716: Jpackage functionality to let users choose whether to create 
> shortcuts

Marked as reviewed by almatvee (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2882

Reply via email to