On Wed, 10 Mar 2021 02:31:28 GMT, Ian Graves <igra...@openjdk.org> wrote:
>> This fixes a zero-adding issue observed in the hex float conversion. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Updating Formatter copyright date Looks good to me. BTW apart from this issue, I just noticed that in the chart in the `Formatter` class spec, there are two spaces (two NBSPs) for the `extra space` flag: * <tr><th scope="row" style="vertical-align:top"> <code>' '</code> * <td style="vertical-align:top"> <code>'\u0020'</code> * <td> Requires the output to include a single extra space * (<code>'\u0020'</code>) for non-negative values. * * <p> If both the {@code '+'} and <code>' '</code> flags are given * then an {@link IllegalFormatFlagsException} will be thrown. ``` This might be fixed sometime. ------------- Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2881