On Sat, 13 Mar 2021 08:38:16 GMT, Ioi Lam <ik...@openjdk.org> wrote: >> Alexey Semenyuk has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8263536: Add missing @compile tags to jpackage tests > > Changes requested by iklam (Reviewer).
@kevinrushforth I plan to resolve JDK-8263474 manually as "Delivered". Would this work? > test/jdk/tools/jpackage/windows/WinDirChooserTest.java line 44: > >> 42: * @requires (os.family == "windows") >> 43: * @modules jdk.jpackage/jdk.jpackage.internal >> 44: * @compile WinDirChooserTest.java > > Changes like this one is not necessary. `@run` will build WinDirChooserTest > automatically. > > `@compile` should be added only when necessary, like WinInstallerUiTest.java It is better to have `@compile` everywhere for consistency. The proper way to run tests is by passing test class name as an argument for test runner, test class should not have `main()` and should have `@Test` annotation for test methods. Some tests have not been updated to follow this design and adding `@compile` to them doesn't make a difference now. But eventually they will be updated and they will need `@compile` anyways. ------------- PR: https://git.openjdk.java.net/jdk/pull/2975
