On Wed, 17 Mar 2021 17:14:22 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>> That complicates the test and the child quite a bit for minimal gain.
>
> Arbitrary time out has been a reliable source of intermittent failures.
> 
> Since we have spent a lot of time analyzing this failure, I think it's 
> worthwhile to fix it properly, which doesn't seem that complicated. That's 
> better than the same bug happening again a year later and a different set of 
> people would spend hours to analyze it again.

I don't think this is CPU starvation but memory exhaustion. _beginthreadex 
fails with EACCES if it has no resources to start the thread, which in this 
case probably means memory (the other possibility would be out-of-HANDLE-space 
but seeing that the child just started I don't see how this could be).

Should we harden tests against resource starvation like this, or rather require 
the test machine to be beefy enough for tests? Also, I don't understand, if the 
child has not enough resources to bring the VM fully up how waiting on either 
stream would help.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3049

Reply via email to