On Thu, 18 Mar 2021 19:43:10 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> This converts jpackage to use `Stream.toList()` instead of 
>> `Stream.collect(Collectors.toList())`. One piece of code was modified to not 
>> mutate a list in addition to one test that used a mutating sort on a list. 
>> The rest of the changes are simple substitutions.
>
> @igraves as a "best practice" try to avoid doing a force-push to a branch 
> with an active code review. It makes it hard for reviewers to see what has 
> changed. If you need to merge changes from master, use "git merge master" 
> instead.
> 
> @alexeysemenyukoracle @sashamatveev Can you re-review this so Ian can 
> integrate it?

@kevinrushforth Understood, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2997

Reply via email to