Hi Lance, Thanks a lot for your comments! The CSR has been proposed at https://bugs.openjdk.java.net/browse/JDK-8263793, but it seems I can not add it to the github PR. I am WIP on the test coverage, will update the PR when it is ready.
BRs, Lin From: Lance Andersen <lance.ander...@oracle.com> Date: Thursday, March 18, 2021 at 11:25 PM To: Lin Zang <lz...@openjdk.java.net> Cc: "core-libs-dev@openjdk.java.net" <core-libs-dev@openjdk.java.net> Subject: Re: RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields(Internet mail) Hi Lin, Thank you for your contribution. I have no looked at this in any detail. A few general comments: · This will require a CSR · Please update your PR to include test coverage demonstrating that the data can be written and then read back Best, Lance On Mar 18, 2021, at 6:57 AM, Lin Zang <lz...@openjdk.java.net<mailto:lz...@openjdk.java.net>> wrote: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields ------------- Commit messages: - remove trailing spaces - 4890732: support optional GZIP fields in GZIPOutputStream Changes: https://git.openjdk.java.net/jdk/pull/3072/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3072&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-4890732 Stats: 184 lines in 1 file changed: 184 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3072.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3072/head:pull/3072 PR: https://git.openjdk.java.net/jdk/pull/3072 [cid:image001.gif@01D71CAA.9557DB60] Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com<mailto:lance.ander...@oracle.com>
