On Mon, 22 Mar 2021 07:19:28 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Please review this change to java.util.Timer, replacing the use of >> deprecated finalization-based cleanup with use of java.lang.ref.Cleaner. >> >> In addition, Timer.cancel now cancels any later execution of the the no >> longer relevant cleanup. >> >> Testing: >> mach5 tier1 >> New AutoStop test verifies the specified cleanup behavior. >> (There are existing tests involving Timer.cancel.) > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > dholmes review The change looks good to me (though making the ThreadReaper ctor non-public would be nice). ------------- Marked as reviewed by bchristi (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3106