On Tue, 6 Apr 2021 14:39:07 GMT, Andy Herrick <[email protected]> wrote:
>> Use value of `--icon` jpackage CLI option to set icon for exe installers.
>
> Marked as reviewed by herrick (Reviewer).
One question -
ICON is only a valid option for creating app launcher. If creating an
installer using --app-image option it would not be a vlid option.
Does this change imply we should change ValidOptions to change:
options.put(CLIOptions.ICON.getId(), USE.LAUNCHER);
to
options.put(CLIOptions.ICON.getId(), USE.ALL);
-------------
PR: https://git.openjdk.java.net/jdk/pull/3347
