On Thu, 15 Apr 2021 01:24:04 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> - Issue was reproducible when install-dir points to some invalid location. > - Fixed by defaulting DMG drag and drop location to /Applications folder and > --install-dir will be ignored with warning for DMG. > - I do not see any way to support other valid, but uncommon locations for > drag and drop. For example: /Users/USERNAME/Applications is not possible to > support since user name is not known. /usr/bin requires root privileges and > should contain symbolic links. Locations which does not exist also not > possible to support, since DMG cannot create paths. So > /Applications/MyCompany is not possible for DMG. Doesn't much of this argument apply to pkg builds too ? I hate to abandon install-dir option entirely for dmg, and just printing a warning and ignoring the argument is contrary to what is done for other arguments. Is there any way, in the apple script, to check if the install-dir exists, and to use it if it does ? Also wouldn't it be useful (for both pkg and dmg) to have ability to install into the users home directory ? just specifying ~ or ~/Applications gets expanded before going in script if not quoted, and doesn't work if it is quoted. Unless we define a meaning for non-fully qualified path in install-dir that should probably be a hard error.. ------------- PR: https://git.openjdk.java.net/jdk/pull/3505
