On Mon, 19 Apr 2021 10:44:04 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> Peter Levart has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix overflow checking logic, add test for it, avoid branch in loop, add
>> 1-char strings to JHM test
>
> test/micro/org/openjdk/bench/java/util/StringJoinerBenchmark.java line 48:
>
>> 46: @Warmup(iterations = 10, time = 500, timeUnit = TimeUnit.MILLISECONDS)
>> 47: @Measurement(iterations = 10, time = 500, timeUnit =
>> TimeUnit.MILLISECONDS)
>> 48: @Fork(value = 1, jvmArgsAppend = {"-Xms1g", "-Xmx1g"})
>
> In general I think it's prudent to default to at least 3 forks, to catch
> issues with run-to-run variance.
Thanks, Claes. Will change that to 3 forks before pushing.
Any more comments? Will wait for a day, then push it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3501
