On Tue, 27 Apr 2021 18:43:11 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8266054: Review comments resolution. > > I noticed the tests are only updated for int and long, is that intentional? > The HotSpot changes in some cases seem to imply all integral types are > supported via the use of `is_integral_type`, contradicted by the use of > `is_subword_type`. > > I would recommend trying to leverage Integer/Long.rotateLeft/Right > implementations. They are not available for byte/short, so lets add specific > methods in those cases, that should make the Java op implementation clearer. Hi @PaulSandoz , thanks your comments have been addressed. ------------- PR: https://git.openjdk.java.net/jdk/pull/3720