On Tue, 4 May 2021 14:10:52 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jason Zaugg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use pattern matching instanceof > > src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2223: > >> 2221: synchronized (zfch) { >> 2222: n = zfch.position(pos).read(bb); >> 2223: } > > @LanceAndersen Are you planning to look at this? Do you mind checking the > async close case to make sure that the synchronization isn't masking anything? > > Also just to point out that pattern matching for instanceof ca be used here. Yes, I plan to look at this. It would also be good to have a couple of additional reviews as well :-) ------------- PR: https://git.openjdk.java.net/jdk/pull/3853