On Fri, 7 May 2021 00:02:56 GMT, Yumin Qi <mi...@openjdk.org> wrote: >> test/hotspot/jtreg/runtime/cds/appcds/jcmd/JCmdTestFileSafety.java line 78: >> >>> 76: print2ln(test_count++ + " Set target dir not writable, do >>> dynamic dump"); >>> 77: setKeepArchive(true); >>> 78: outputDirFile.setWritable(true); >> >> Should the comment be `// Set target dir writable ...` ? (since you're >> setting the dir to writable at line 78) > > The comment is for the testing item --- that is consistent with println > contents. > The first set 'true' is for get the archive and keep the archive, the real > test is after set it to 'false', the test will fail and we check the previous > archive still available.
I see. ------------- PR: https://git.openjdk.java.net/jdk/pull/3886
