Hi Mandy, impressive work ! I think that the method that are a caller-sensitive adapter (the one that takes a supplementary class as last parameter) should be annotated with a specific JDK internal annotation, so the link between the caller sensitive method and it's adapter is obvious for the humans that read the code.
Otherwise, i've only taken a look to the parts of the code that are using ASM. This line is weird, it uses 52 which is Java 8 https://github.com/mlchung/jdk/commit/320efd2e5697627243f6fe058485fb8708a0cd41#diff-4e4fca8bb2eb6320ff485ee724248e1641b4bb3f6dbae8526e87c5cf15905d9aR1262 Perhaps all versions should be updated to 61 (Java 17), unit the internal version of ASM is refreshed so the constant V17 can be used. Rémi ----- Mail original ----- > De: "mandy chung" <mandy.ch...@oracle.com> > À: "core-libs-dev" <core-libs-dev@openjdk.java.net>, "hotspot compiler" > <hotspot-compiler-...@openjdk.java.net> > Envoyé: Mardi 11 Mai 2021 22:42:01 > Objet: Draft JEP: Reimplement Core Reflection on Method Handles > This draft JEP is a proposal to reimplement core reflection on top of > method handles: > https://bugs.openjdk.java.net/browse/JDK-8266010 > > Feedback is welcome. The prototype is at [1]. > > Mandy > [1] https://github.com/mlchung/jdk/tree/reimplement-method-invoke
