On Wed, 12 May 2021 18:46:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @AlanBateman comments > > src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 60: > >> 58: // Sets the ServicesCatalog for the specified loader using archived >> objects. >> 59: private static void setArchivedServicesCatalog( >> 60: ArchivedClassLoaders archivedClassLoaders, ClassLoader >> loader) > > Thanks for the update. The formatting on L60 is messed now, can't the > ArchivedClassLoaders go on the previous line? I don't have any other > comments, it's worked out well. How about the latest version (4cd981c)? I removed the `archivedClassLoaders` argument; this also makes the callers simpler. ------------- PR: https://git.openjdk.java.net/jdk/pull/3992
